Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin_memory -> dataloader_pin_memory #9874

Merged
merged 2 commits into from
Jan 28, 2021
Merged

pin_memory -> dataloader_pin_memory #9874

merged 2 commits into from
Jan 28, 2021

Conversation

abhishekkrthakur
Copy link
Contributor

@abhishekkrthakur abhishekkrthakur commented Jan 28, 2021 •
edited
Loading

Ref: #9857 (comment)

This PR adds a new argument dataloader_pin_memory to TrainingArguments. You can use this to pin memory in DataLoader.

stas00
stas00 reviewed Jan 28, 2021
View reviewed changes
Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you, @abhishekkrthakur

@stas00 stas00 self-requested a review January 28, 2021 18:33
sgugger
sgugger approved these changes Jan 28, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Also, can you take the time to write short descriptions of your PR please? The PRs are linked to the release notes and some users use the descriptions to get some info about the features.

@abhishekkrthakur
Copy link
Contributor Author

Updated with review comments. Please let me know if/when it's okay to merge :)

@sgugger
Copy link
Collaborator

sgugger commented Jan 28, 2021

Good for me, thanks a lot!

@stas00
Copy link
Contributor

stas00 commented Jan 28, 2021

this is much better, thank you for the adjustment, @abhishekkrthakur

@abhishekkrthakur abhishekkrthakur merged commit bc109ae into master Jan 28, 2021
@abhishekkrthakur abhishekkrthakur deleted the pin_memory_2 branch January 28, 2021 20:10
Qbiwan pushed a commit to Qbiwan/transformers that referenced this pull request Jan 31, 2021
@abhishekkrthakur @Qbiwan
pin_memory -> dataloader_pin_memory (huggingface#9874)
5b824a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stas00 stas00 stas00 approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishekkrthakur @sgugger @stas00